RFR: 8339346: GenShen: Remove even more stale TODOs

[Kelvin Nilsen]

On Tue, 3 Sep 2024 22:14:13 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Some of these have been done, some of these will not be done, some have been moved into our ticketing system, some of them are done in this PR.
>
> src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.hpp line 73:
> 
>> 71: 
>> 72:   inline bool allocated_after_mark_start(oop obj) const;
>> 73:   inline bool allocated_after_mark_start(const HeapWord* addr) const;
> 
> Any reason to remove the arg const-ness? Seems to hold and gives you a sense of the methods not modifying the args. Do we gain anything from removing the arg-constness? (I do see the "TODO" comment, but I'd erro towards removing the TODO comment and leaving the arg const-ness in place.

Agree with Ramki here, unless there's a reason we prefer non-const args.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1742828964