RFR: 8339346: GenShen: Remove even more stale TODOs

Kelvin Nilsen kdnilsen at openjdk.org
Wed Sep 4 00:25:35 UTC 2024


On Wed, 4 Sep 2024 00:18:30 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Agree with Ramki here, unless there's a reason we prefer non-const args.
>
> I believe it is confusing because `oop` is a `typedef` for a pointer `oopDesc*`. So, the `const` here applies to the typedef and not to the underlying type (that is, we could still call non-const methods on `oop` inside the function, but we cannot change what `oop` points to). Also, these `const` modifiers are not present upstream.

ok.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1742837116


More information about the shenandoah-dev mailing list