RFR: 8339346: GenShen: Remove even more stale TODOs

Y. Srinivas Ramakrishna ysr at openjdk.org
Wed Sep 4 15:36:03 UTC 2024


On Wed, 4 Sep 2024 00:22:33 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> I believe it is confusing because `oop` is a `typedef` for a pointer `oopDesc*`. So, the `const` here applies to the typedef and not to the underlying type (that is, we could still call non-const methods on `oop` inside the function, but we cannot change what `oop` points to). Also, these `const` modifiers are not present upstream.
>
> ok.

Good point, so what one wanted here was `oop const obj` ... :-) But that might cause other changes, and not a big deal here, since it's fewer diffs wrt upstream, as you state.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1744017345


More information about the shenandoah-dev mailing list