RFR: 8339611: GenShen: Simplify ShenandoahOldHeuristics::trigger_collection_if_fragmented [v3]

[Y. Srinivas Ramakrishna]

On Tue, 10 Sep 2024 23:38:31 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 552:
>> 
>>> 550: // is required to represent the memory currently used within the old generation.  This trigger looks specifically
>>> 551: // at density of the old-gen spanned region.  A different mechanism triggers old-gen GC if the total number of
>>> 552: // old-gen regions (regardless of how close the regions are to one another) grows beyond an anticipated growth target.
>> 
>> I realize this is a private API / work method. Would still be good to place the documentation comment in the .hpp file.
>> 
>> 
>> // If the old generation is fragmented, set appropriate collection triggering signals.
>
> In this implementation, I'd then describe how the fragmentation is computed.

Also, I'd avoid using "trigger", and instead say "set_trigger", since the actual collection will happen later, as far as I understand.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/492#discussion_r1752936935