RFR: 8339611: GenShen: Simplify ShenandoahOldHeuristics::trigger_collection_if_fragmented [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Sep 11 17:20:24 UTC 2024


On Tue, 10 Sep 2024 23:39:45 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> In this implementation, I'd then describe how the fragmentation is computed.
>
> Also, I'd avoid using "trigger", and instead say "set_trigger", since the actual collection will happen later, as far as I understand.

Thanks.  Adding comment and changing name to set_trigger_if_old_is_fragmented().  Also, renaming trigger_collection_if_overgown() to set_trigger_if_old_is_overgrown().

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/492#discussion_r1755198905


More information about the shenandoah-dev mailing list