RFR: 8339616: GenShen: Introduce new state to distinguish promote-in-place phase as distinct from concurrent evacuation [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Sep 23 19:35:08 UTC 2024
On Mon, 23 Sep 2024 19:25:45 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Do not enter oom-during-evac protocol when only promoting regions in place
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 526:
>
>> 524: void ShenandoahConcurrentGC::entry_promote_in_place() {
>> 525: shenandoah_assert_generational();
>> 526:
>
> Do you also want to assert that collection set is empty?
The other approach might be to _always_ have a separate pre-evac phase that promotes in place before actual evac to follow (even when collection set is non-empty).
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/503#discussion_r1771971900
More information about the shenandoah-dev
mailing list