RFR: 8339616: GenShen: Introduce new state to distinguish promote-in-place phase as distinct from concurrent evacuation [v2]

William Kemper wkemper at openjdk.org
Mon Sep 23 20:54:00 UTC 2024


On Mon, 23 Sep 2024 19:30:38 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 526:
>> 
>>> 524: void ShenandoahConcurrentGC::entry_promote_in_place() {
>>> 525:   shenandoah_assert_generational();
>>> 526: 
>> 
>> Do you also want to assert that collection set is empty?
>
> The other approach might be to _always_ have a separate pre-evac phase that promotes in place before actual evac to follow (even when collection set is non-empty).

Yes, added this assertion in f409f645e1.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/503#discussion_r1772060956


More information about the shenandoah-dev mailing list