RFR: 8344883: Do not use mtNone if we know the tag type [v2]
Gerard Ziemski
gziemski at openjdk.org
Tue Apr 1 16:40:36 UTC 2025
On Fri, 28 Mar 2025 08:03:28 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> work
>
> test/hotspot/gtest/runtime/test_committed_virtualmemory.cpp line 94:
>
>> 92: const size_t page_sz = os::vm_page_size();
>> 93: const size_t size = num_pages * page_sz;
>> 94: char* base = os::reserve_memory(size, mtThreadStack, !ExecMem);
>
> Suggestion:
>
> char* base = os::reserve_memory(size, mtThreadStack);
ExecMem is a parameter, which could be false, so that would make it `true` for `reserve_memory`, so need to keep it?
> test/hotspot/gtest/runtime/test_committed_virtualmemory.cpp line 162:
>
>> 160: const size_t num_pages = 4;
>> 161: const size_t size = num_pages * page_sz;
>> 162: char* base = os::reserve_memory(size, mtTest, !ExecMem);
>
> Suggestion:
>
> char* base = os::reserve_memory(size, mtTest);
ExecMem is a parameter, that could be false.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2023206394
PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2023207421
More information about the shenandoah-dev
mailing list