RFR: 8344883: Do not use mtNone if we know the tag type [v2]
Gerard Ziemski
gziemski at openjdk.org
Tue Apr 1 16:47:35 UTC 2025
On Fri, 28 Mar 2025 08:18:12 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> work
>
> src/hotspot/share/memory/allocation.inline.hpp line 61:
>
>> 59: size_t size = size_for(length);
>> 60:
>> 61: char* addr = os::reserve_memory(size, mem_tag, !ExecMem);
>
> Suggestion:
>
> char* addr = os::reserve_memory(size, mem_tag);
ExecMem can be false?
> src/hotspot/share/memory/allocation.inline.hpp line 78:
>
>> 76: size_t size = size_for(length);
>> 77:
>> 78: char* addr = os::reserve_memory(size, mem_tag, !ExecMem);
>
> Suggestion:
>
> char* addr = os::reserve_memory(size, mem_tag);
ExecMem can be false?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2023215520
PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2023217448
More information about the shenandoah-dev
mailing list