RFR: 8354547: REDO: Force clients to explicitly pass mem_tag value, even if it is mtNone

[Gerard Ziemski]

On Mon, 14 Apr 2025 19:49:54 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> Redo for a follow-up to https://github.com/openjdk/jdk/pull/21843. Here we are focusing on removing the mem tag paremeter with default value of mtNone, to force everyone to provide mem tag, if known.
> 
> I tried to fill in tag, when I was pretty certain that I had the right type.
> 
> At least one more follow-up will be needed after this, to change the remaining mtNone to valid values.
> 
> Testing: passes Mach5 tier1-5

The fix for the build break from the original fix was super simple, from:


          char* p = os::attempt_reserve_memory_at(mapped_base_address, prot_zone_size,
                                                  false, MemTag::mtClassShared);


to


          char* p = os::attempt_reserve_memory_at(mapped_base_address, prot_zone_size,
                                                  mtClassShared, false);

@jdksjolen @stefank @afshin-zafari re-do.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24634#issuecomment-2802839371
PR Comment: https://git.openjdk.org/jdk/pull/24634#issuecomment-2802841516