RFR: 8372543: Shenandoah: undercalculated the available size when soft max takes effect
William Kemper
wkemper at openjdk.org
Wed Dec 3 23:51:59 UTC 2025
On Wed, 3 Dec 2025 23:24:38 GMT, Rui Li <duke at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 632:
>>
>>> 630: size_t get_usable_free_words(size_t free_bytes) const;
>>> 631:
>>> 632: void log_freeset_stats(ShenandoahFreeSetPartitionId partition_id, LogStream& ls);
>>
>> `log_freeset_stats` should probably be `private`.
>
> I thought it was private already? The `private` starts from [here](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp#L478). Or, if you expand this section a bit to line 636, another `public` starts after these declaration.
:face-palm:, you're right. I misread the diff.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28622#discussion_r2586958311
More information about the shenandoah-dev
mailing list