RFR: 8372543: Shenandoah: undercalculated the available size when soft max takes effect [v3]
Rui Li
duke at openjdk.org
Thu Dec 4 18:51:17 UTC 2025
On Wed, 3 Dec 2025 18:44:37 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Rui Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unused freeset includes
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 258:
>
>> 256: size_t min_threshold = min_free_threshold();
>> 257: if (available < min_threshold) {
>> 258: log_trigger("Free (Soft mutator free) (%zu%s) is below minimum threshold (%zu%s)",
>
> Changing this will break some log parsers, do we really need this?
Talked offline. `Free` is overloaded in logs. Sometimes it means soft free, sometimes it means total free. Make it as `Free (Soft)` here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28622#discussion_r2590194712
More information about the shenandoah-dev
mailing list