RFR: 8350314: Shenandoah: Capture thread state sync times in GC timings [v2]

William Kemper wkemper at openjdk.org
Wed Feb 26 00:34:52 UTC 2025


On Wed, 26 Feb 2025 00:05:12 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> Sorry I should have read the code in `op_init_update_refs`, it doesn't change GC state, we can remove the the call of `propagate_gc_state_to_all_threads` to clean up code a little bit, it was missed when you replaced the init_update_refs pause with handshake.
>
> For `final_roots`, I think I should leave it as it is in this PR, later you will remove the timings and gc state propagation into a handshake anyway.

Yep, I agree. Thank you!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23759#discussion_r1970726624


More information about the shenandoah-dev mailing list