RFR: 8350314: Shenandoah: Capture thread state sync times in GC timings [v2]
Xiaolong Peng
xpeng at openjdk.org
Wed Feb 26 02:17:36 UTC 2025
On Wed, 26 Feb 2025 00:31:03 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> For `final_roots`, I think I should leave it as it is in this PR, later you will remove the timings and gc state propagation into a handshake anyway.
>
> Yep, I agree. Thank you!
To remove propagate_gc_state_to_all_threads, `_gc_state_changed` has to be set to false in `ShenandoahHeap::concurrent_prepare_for_update_refs`, I have updated PR to fix it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23759#discussion_r1970795124
More information about the shenandoah-dev
mailing list