RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]

David Holmes dholmes at openjdk.org
Mon Jan 13 05:05:49 UTC 2025


On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> There are a lot of format modifiers that are noisy and unnecessary in the code.  This change removes the INTX variants.  It's not that disruptive even for backporting because %z modifier has been available for a long time so should backport fine.  This was mostly done with a sed script plus some hand fixups.
>> 
>> Testing mach5 and other platform cross compilations in progress.  Opening this for GHA testing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore copyright and macro.

Sorry for a "dumb" question but `%z` is for size_t arguments, so why are we using it to replace INTX/UINTX_FORMAT ??? I get that size_t and intx happen to be the same size but still ... if I see  `%z` I expect to see a size_t argument passed in.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22916#pullrequestreview-2545711471


More information about the shenandoah-dev mailing list