RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]
Coleen Phillimore
coleenp at openjdk.org
Mon Jan 13 13:29:45 UTC 2025
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the code. This change removes the INTX variants. It's not that disruptive even for backporting because %z modifier has been available for a long time so should backport fine. This was mostly done with a sed script plus some hand fixups.
>>
>> Testing mach5 and other platform cross compilations in progress. Opening this for GHA testing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Restore copyright and macro.
They are interchangeable and some places used UINTX_FORMAT when they should have used SIZE_FORMAT.
Better to have just one and just use %zu, which looks better in the format specifiers. I'm going to do SIZE_FORMAT next but still negotiating how to handle review tedium.
The error message can be confusing though because the error message for %z refers to size_t. But some of our use of intx should probably be size_t.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22916#issuecomment-2587101349
More information about the shenandoah-dev
mailing list