RFR: 8351700: Remove code conditional on BarrierSetNMethod being null

Tom Rodriguez never at openjdk.org
Tue Mar 11 19:53:00 UTC 2025


On Tue, 11 Mar 2025 19:29:05 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> All GCs started needing nmethod entry barriers as of loom so there's no longer any need to test for null nmethod entry barriers.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 6549:

> 6547:     BarrierSetNMethod* bs_nm = BarrierSet::barrier_set()->barrier_set_nmethod();
> 6548:     if (bs_nm != nullptr) {
> 6549:       StubRoutines::_method_entry_barrier = generate_method_entry_barrier();

Shouldn't you have kept this line?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23996#discussion_r1990025685


More information about the shenandoah-dev mailing list