RFR: 8351700: Remove code conditional on BarrierSetNMethod being null [v2]

Doug Simon dnsimon at openjdk.org
Tue Mar 11 20:01:00 UTC 2025


On Tue, 11 Mar 2025 19:50:18 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revived accidentally deleted code
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 6549:
> 
>> 6547:     BarrierSetNMethod* bs_nm = BarrierSet::barrier_set()->barrier_set_nmethod();
>> 6548:     if (bs_nm != nullptr) {
>> 6549:       StubRoutines::_method_entry_barrier = generate_method_entry_barrier();
> 
> Shouldn't you have kept this line?

Absolutely!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23996#discussion_r1990039724


More information about the shenandoah-dev mailing list