RFR: 8352185: Shenandoah: Invalid logic for remembered set verification [v14]
Xiaolong Peng
xpeng at openjdk.org
Wed Mar 26 20:37:59 UTC 2025
On Wed, 26 Mar 2025 00:30:55 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> very cool!
>
> May be as intended earlier, leave a documentation comment between lines 697 & 698 along the lines of Kelvin's comment:
>
>
> // After we swap card table below, the write-table is all clean, and the read table holds
> // cards dirty prior to the start of GC. Young and bootstrap collection will update
> // the write card table as a side effect of remembered set scanning. Global collection will
> // update the card table as a side effect of global marking of old objects.
Sorry, I added comments as you suggested but forgot to push.Now the comment has been added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24092#discussion_r2014959494
More information about the shenandoah-dev
mailing list