RFR: 8344883: Do not use mtNone if we know the tag type [v2]

[Gerard Ziemski]

On Fri, 28 Mar 2025 08:22:09 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   work
>
> src/hotspot/share/runtime/os.cpp line 2130:
> 
>> 2128:     log_trace(os, map)(ERRFMT, ERRFMTARGS);
>> 2129:     log_debug(os, map)("successfully attached at " PTR_FORMAT, p2i(result));
>> 2130:     MemTracker::record_virtual_memory_reserve((address)result, bytes, CALLER_PC, mtNone);
> 
> I think attempt_reserve_memory_between should provide the correct mem tag.

I wasn't sure what that is here, we can do this in a follow up?

> src/hotspot/share/runtime/os.cpp line 2336:
> 
>> 2334:   if (result != nullptr) {
>> 2335:     // The memory is committed
>> 2336:     MemTracker::record_virtual_memory_reserve_and_commit((address)result, size, CALLER_PC, mtNone);
> 
> reserve_memory_special should take a mem tag, but I guess you intend to do that as a follow-up RFE?

Yes, I'm trying to keep changes small and not overdo it. There will be follow-ups.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2021591591
PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2021590157