RFR: 8344883: Do not use mtNone if we know the tag type [v2]
Stefan Karlsson
stefank at openjdk.org
Mon Mar 31 19:28:09 UTC 2025
On Mon, 31 Mar 2025 18:42:16 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> src/hotspot/share/runtime/os.cpp line 2130:
>>
>>> 2128: log_trace(os, map)(ERRFMT, ERRFMTARGS);
>>> 2129: log_debug(os, map)("successfully attached at " PTR_FORMAT, p2i(result));
>>> 2130: MemTracker::record_virtual_memory_reserve((address)result, bytes, CALLER_PC, mtNone);
>>
>> I think attempt_reserve_memory_between should provide the correct mem tag.
>
> I wasn't sure what that is here, we can do this in a follow up?
My suggestion was to change `attempt_reserve_memory_between` to take MemTag as an argument. It's OK to do that as a follow-up PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2021646441
More information about the shenandoah-dev
mailing list