RFR: 8373595: A new ObjectMonitorTable implementation [v3]
Fredrik Bredberg
fbredberg at openjdk.org
Tue Feb 10 14:11:25 UTC 2026
On Fri, 30 Jan 2026 00:15:05 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated shared code after review comments
>
> src/hotspot/share/runtime/objectMonitorTable.cpp line 417:
>
>> 415: if (result != curr) {
>> 416: // Somebody else racingly started rehashing; try again.
>> 417: new_table = result;
>
> First, how is this "trying again"? I see no loop or repeated action.
>
> Second, you seem to be leaking the table you just allocated.
**First:** You're right "try again" was not a good comment, but the "repeated action" is taking place because we recursively call rebuild again at the last line.
**Second:** Good catch! I've stopped the leaking.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2788181855
More information about the shenandoah-dev
mailing list