RFR: 8373595: A new ObjectMonitorTable implementation [v3]

[Fredrik Bredberg]

On Fri, 30 Jan 2026 00:10:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated shared code after review comments
>
> src/hotspot/share/runtime/synchronizer.cpp line 1204:
> 
>> 1202:       }
>> 1203:     }
>> 1204: #endif
> 
> I find it very hard to see how rebuilding relates to the deleted debug code? Maybe this is just a quirk of the diff: we don't need the old debug code; we do need the new rebuild code - they aren't actually related in any way. ?

The deleted assert code was there to make sure all of the monitors were actually deleted from the OMT.
The new OMT doesn't have a `contains_monitor` implementation, and it's not easy to write, so we decided to remove the assert code. So you're assumption is spot on: _"Maybe this is just a quirk of the diff: we don't need the old debug code; we do need the new rebuild code - they aren't actually related in any way."_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2789261879