RFR: 8373595: A new ObjectMonitorTable implementation [v8]

Fredrik Bredberg fbredberg at openjdk.org
Fri Feb 20 12:57:21 UTC 2026


On Thu, 19 Feb 2026 14:04:38 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp line 638:
>> 
>>> 636:   // which case we need to take the slow path.
>>> 637:   __ testb(gc_state, ShenandoahHeap::WEAK_ROOTS);
>>> 638:   __ jccb(Assembler::notZero, slowpath);
>> 
>> Suggestion:
>> 
>>   __ jcc(Assembler::notZero, slowpath);
>
> It seems saner to not assume 8-bit offsets to slow-path, and other similar jcc to slow-path in fast_lock() also use jcc and not jccb.

I agree, so I changed it. Thanks for pointing that out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2833055664


More information about the shenandoah-dev mailing list