RFR: 8373595: A new ObjectMonitorTable implementation [v8]

Roman Kennke rkennke at openjdk.org
Thu Feb 19 14:18:10 UTC 2026


On Thu, 19 Feb 2026 14:02:59 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8373595_new_object_monitor_table
>>  - Second update for Axel
>>  - Updated for RealFYang
>>  - Updated for Andrew
>>  - Updated for Axel
>>  - Updated shared code after review comments
>>  - Updated all platforms after review comments
>>  - 8373595: A new ObjectMonitorTable implementation
>
> src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp line 638:
> 
>> 636:   // which case we need to take the slow path.
>> 637:   __ testb(gc_state, ShenandoahHeap::WEAK_ROOTS);
>> 638:   __ jccb(Assembler::notZero, slowpath);
> 
> Suggestion:
> 
>   __ jcc(Assembler::notZero, slowpath);

It seems saner to not assume 8-bit offsets to slow-path, and other similar jcc to slow-path in fast_lock() also use jcc and not jccb.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2828085170


More information about the shenandoah-dev mailing list