RFR: 8373595: A new ObjectMonitorTable implementation [v8]

[Fredrik Bredberg]

On Thu, 19 Feb 2026 14:06:06 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8373595_new_object_monitor_table
>>  - Second update for Axel
>>  - Updated for RealFYang
>>  - Updated for Andrew
>>  - Updated for Axel
>>  - Updated shared code after review comments
>>  - Updated all platforms after review comments
>>  - 8373595: A new ObjectMonitorTable implementation
>
> src/hotspot/share/runtime/objectMonitorTable.cpp line 77:
> 
>> 75: //
>> 76: // Both the new and (potentially several) old table(s) may exist at the same
>> 77: // time. The newest is allays called the "current", and the older ones are
> 
> Suggestion:
> 
> // time. The newest is always called the "current", and the older ones are

Fixed

> src/hotspot/share/runtime/objectMonitorTable.cpp line 81:
> 
>> 79: //
>> 80: // As soon as we have allocated and linked in the new "current" OMT, all new
>> 81: // monitor pointers will be added to the new tale. Effectively making the
> 
> Suggestion:
> 
> // monitor pointers will be added to the new table. Effectively making the

Fixed

> src/hotspot/share/runtime/objectMonitorTable.cpp line 82:
> 
>> 80: // As soon as we have allocated and linked in the new "current" OMT, all new
>> 81: // monitor pointers will be added to the new tale. Effectively making the
>> 82: // atomic switch from "old current" to "new current" a linerization point.
> 
> Suggestion:
> 
> // atomic switch from "old current" to "new current" a linearization point.

Fixed

> src/hotspot/share/runtime/objectMonitorTable.cpp line 495:
> 
>> 493:           // In the current implementation the deflation thread drives
>> 494:           // the rebuilding, and it will already have removed any entry
>> 495:           // it has deflated. The assert is ony here to make sure.
> 
> Suggestion:
> 
>           // it has deflated. The assert is only here to make sure.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2833065135
PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2833056753
PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2833058680
PR Review Comment: https://git.openjdk.org/jdk/pull/29383#discussion_r2833057521