RFR: 8312116: GenShen: make instantaneous allocation rate triggers more timely [v4]
Kelvin Nilsen
kdnilsen at openjdk.org
Thu Jan 15 17:34:49 UTC 2026
On Thu, 8 Jan 2026 21:29:23 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 65 commits:
>>
>> - Fix comment
>> - Use PROPERFMT macros
>> - Simplify code flow: reviewer suggestion
>> - Merge remote-tracking branch 'jdk/master' into accelerated-triggers
>> - Remove develop/debug instrumentation
>> - add another override
>> - Change type of command-line args
>> - fix white space
>> - Add override to virtual methods
>> - Fix race between allocation reporting and querying
>> - ... and 55 more: https://git.openjdk.org/jdk/compare/dd20e915...7f3a6d1e
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 145:
>
>> 143: }
>> 144:
>> 145: double ShenandoahAdaptiveHeuristics::get_most_recent_wake_time() const {
>
> This introduces a cyclic dependency between control/regulator threads and the heuristics. Since control/regulator threads already _know_ about heuristics, could we instead have the threads invoke setters on the heuristics to provide these values?
I've refactored this code now according to your suggestion. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2695322992
More information about the shenandoah-dev
mailing list