RFR: 8312116: GenShen: make instantaneous allocation rate triggers more timely [v4]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Jan 15 17:40:57 UTC 2026


On Thu, 8 Jan 2026 22:28:41 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 65 commits:
>> 
>>  - Fix comment
>>  - Use PROPERFMT macros
>>  - Simplify code flow: reviewer suggestion
>>  - Merge remote-tracking branch 'jdk/master' into accelerated-triggers
>>  - Remove develop/debug instrumentation
>>  - add another override
>>  - Change type of command-line args
>>  - fix white space
>>  - Add override to virtual methods
>>  - Fix race between allocation reporting and querying
>>  - ... and 55 more: https://git.openjdk.org/jdk/compare/dd20e915...7f3a6d1e
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp line 73:
> 
>> 71:   bool is_spiking(double rate, double threshold) const;
>> 72: 
>> 73:   double interval() const {
> 
> Not seeing where these new methods are used.

You are correct.  Removing interval() and last_sample_time().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2695341304


More information about the shenandoah-dev mailing list