RFR: 8312116: GenShen: make instantaneous allocation rate triggers more timely [v4]

[Kelvin Nilsen]

On Thu, 8 Jan 2026 22:46:20 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 65 commits:
>> 
>>  - Fix comment
>>  - Use PROPERFMT macros
>>  - Simplify code flow: reviewer suggestion
>>  - Merge remote-tracking branch 'jdk/master' into accelerated-triggers
>>  - Remove develop/debug instrumentation
>>  - add another override
>>  - Change type of command-line args
>>  - fix white space
>>  - Add override to virtual methods
>>  - Fix race between allocation reporting and querying
>>  - ... and 55 more: https://git.openjdk.org/jdk/compare/dd20e915...7f3a6d1e
>
> src/hotspot/share/gc/shenandoah/shenandoahDegeneratedGC.cpp line 316:
> 
>> 314:   if (progress) {
>> 315:     heap->notify_gc_progress();
>> 316:     heap->shenandoah_policy()->record_success_degenerated(_generation->is_young(), _abbreviated);
> 
> On line 313 above here, we call `policy->record_degenerated` which does everything (and more) that `record_success_degenerated` does. Calling both of them here will increment the various counters twice and is probably not what we want. I think after https://github.com/openjdk/jdk/pull/28834, we shouldn't need `record_success_degenerated` for `ShenandoahCollectorPolicy` at all.

Good catch.  Thanks.  Remove record_success_degenerated().

> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 493:
> 
>> 491:   ShenandoahCodeRoots::initialize();
>> 492: 
>> 493:   // Initialization of controller markes use of varaibles esstablished by initialize_heuristics.
> 
> Suggestion:
> 
>   // Initialization of controller makes use of variables established by initialize_heuristics.

Thanks. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2695380538
PR Review Comment: https://git.openjdk.org/jdk/pull/29039#discussion_r2695384440