RFR: 8357471: GenShen: Share collector reserves between young and old [v29]
Kelvin Nilsen
kdnilsen at openjdk.org
Thu Jan 15 18:43:19 UTC 2026
On Tue, 13 Jan 2026 23:39:46 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 86 commits:
>>
>> - Merge remote-tracking branch 'jdk/master' into share-collector-reserves
>> - Move rebuild free set earlier in an abbreviated GC cycle
>> - Restore deleted assert statement
>> - Move special handling into ShenandoahYoungHeuristics::choose_collection_set_from_regiondata()
>> - fix another typo
>> - Fix typo
>> - Fix confusing comment
>> - Add comment
>> - Merge remote-tracking branch 'jdk/master' into share-collector-reserves
>> - Fix whitespace and comment
>> - ... and 76 more: https://git.openjdk.org/jdk/compare/659b53fe...27ece3e8
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 688:
>
>> 686: void move_unaffiliated_regions_from_collector_to_old_collector(ssize_t regions);
>> 687:
>> 688: inline size_t global_unaffiliated_regions() {
>
> A nit, but all functions defined in the class declaration are implicitly `inline` and the keyword is unnecessary here.
Should I remove inline keyword from all such functions?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25357#discussion_r2695532295
More information about the shenandoah-dev
mailing list