RFR: 8357471: GenShen: Share collector reserves between young and old [v29]

[William Kemper]

On Thu, 15 Jan 2026 18:38:36 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 688:
>> 
>>> 686:   void move_unaffiliated_regions_from_collector_to_old_collector(ssize_t regions);
>>> 687: 
>>> 688:   inline size_t global_unaffiliated_regions() {
>> 
>> A nit, but all functions defined in the class declaration are implicitly `inline` and the keyword is unnecessary here.
>
> Should I remove inline keyword from all such functions?

Some popular IDE's will give a warning for the redundant keyword in their default configuration. The hotspot style guide is silent on the issue. I'm not suggesting we remove the redundant keyword from all files, but if a header has a mix, I'd rather take out the redundant keyword.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25357#discussion_r2699967403