RFR: 199: Set fixVersion in an issue when a commit is integrated

Kevin Rushforth kcr at openjdk.java.net
Thu Dec 12 14:44:22 UTC 2019


On Thu, 12 Dec 2019 14:30:48 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
> 
> Also sets a version for Skara itself!
> 
> Best regards,
> Robin

I don't think it is workable to have the configuration stored in the repo. We will have many cases where there will be upstream and downstream repos where commits will be synced from one to the other and you wouldn't want the fix version to be synced. Also, when forking repos or branches you want to set up and configure the new branch/repo and the master branch at the same time of the fork without pushing a commit to the repo. There are also cases (e.g., for sandbox repos) where you might not want the gitupdater feature enabled, and again it would be unworkable for the config to be in the repo.

I think this is better done via a separate database that maps each repo/branch to a fix version as well as enabling the auto update or not.

-------------

PR: https://git.openjdk.java.net/skara/pull/324


More information about the skara-dev mailing list