Approved and Reviewed by ehelin
Erik Helin
ehelin at openjdk.org
Mon Sep 16 12:32:27 UTC 2019
On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com <duke at openjdk.java.net> wrote:
> Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1
>
> - Set Jupiter version number 5.5.1
> - Introduce Platform Launcher 1.5.1 test runtime dependency
> in order to force Gradle to load the module from the module-path
> - Add missing "requires 'org.junit.jupiter.params'" directives
> in modules: jcheck, storage, vcs, and webrev
>
> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69
>
> ----------------
>
> Commits:
> - 5e253f99: Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1
> - Set Jupiter version number 5.5.1
> - Introduce Platform Launcher 1.5.1 test runtime dependency
> in order to force Gradle to load the module from the module-path
> - Add missing "requires 'org.junit.jupiter.params'" directives
> in modules: jcheck, storage, vcs, and webrev
> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/66
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/66/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/66.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66
@sormuras I _finally_ had a chance to properly review and test this patch. Everything works great, nice job!
----------------
Review status set to Approved by ehelin (project role: Reviewer).
PR: https://git.openjdk.java.net/skara/pull/66
More information about the skara-dev
mailing list