RFR: 351: /contributor command should allow GitHub and OpenJDK usernames

Erik Helin ehelin at openjdk.java.net
Wed Apr 8 11:46:11 UTC 2020


On Wed, 8 Apr 2020 11:37:36 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that improves the usability of the /contributor command.
> 
> Best regards,
> Robin

Looks good, just a minor comment on the username in the example.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java line 41:

> 40:         reply.println();
> 41:         reply.println(" * `/contributor add @" + pr.repository().forge().name() + "-User`");
> 42:         reply.println(" * `/contributor add duke`");

Suggestion:

        reply.println(" * `/contributor add @openjdk-bot`");

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/571


More information about the skara-dev mailing list