RFR: mlrules: applying off-list suggestions

Erik Helin ehelin at openjdk.java.net
Thu Aug 27 17:08:41 UTC 2020

On Thu, 27 Aug 2020 15:13:54 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Thanks, looks good!
> I got the feedback from a build-dev maintainer off-list that the following for build-dev:
>             "bin/idea.sh",
>             "bin/jib.sh",
>             "bin/unshuffle_list.txt",
>             "configure",
>             "doc/building.html",
>             "doc/building.md",
>             "doc/ide.html",
>             "doc/ide.md",
>             "doc/testing.html",
>             "doc/testing.md",
> can be simplified to just:
>              "bin/",
>              "doc/",

Comment from GC maintainer regarding hotspot-gc-dev - change:

The files `src/hotspot/share/memory/heap.{hpp,cpp}` actually for the code heap (and are thus most often reviewed on
hotspot-compiler-dev). As a GC reviewer I should have caught this too ��


PR: https://git.openjdk.java.net/skara/pull/746

More information about the skara-dev mailing list