RFR: mlrules: applying off-list suggestions

[Erik Helin]

On Thu, 27 Aug 2020 17:06:32 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> I got the feedback from a build-dev maintainer off-list that the following for build-dev:
>>             "bin/idea.sh",
>>             "bin/jib.sh",
>>             "bin/unshuffle_list.txt",
>>             "configure",
>>             "doc/building.html",
>>             "doc/building.md",
>>             "doc/ide.html",
>>             "doc/ide.md",
>>             "doc/testing.html",
>>             "doc/testing.md",
>> can be simplified to just:
>>              "bin/",
>>              "doc/",
>
> Comment from GC maintainer regarding hotspot-gc-dev - change:
> "src/hotspot/share/memory/(heap|oop)",
> into
> "src/hotspot/share/memory/oop",
> 
> The files `src/hotspot/share/memory/heap.{hpp,cpp}` actually for the code heap (and are thus most often reviewed on
> hotspot-compiler-dev). As a GC reviewer I should have caught this too ��

I received the following feedback regarding `hotspot-compiler-dev` - change:
src/jdk.aot/share/classes/jdk.tools.jaotc
into just
src/jdk.aot/
and add the following files:
src/hotspot/share/runtime/icache.cpp
src/hotspot/share/runtime/icache.hpp
src/hotspot/share/runtime/registerMap.hpp
src/hotspot/share/runtime/sharedRuntime.cpp
src/hotspot/share/runtime/sharedRuntime.hpp
src/hotspot/share/runtime/sharedRuntimeMath.hpp
src/hotspot/share/runtime/sharedRuntimeTrans.cpp
src/hotspot/share/runtime/sharedRuntimeTrig.cpp
src/hotspot/share/runtime/stubCodeGenerator.hpp
src/hotspot/share/runtime/sweeper.cpp
src/hotspot/share/runtime/sweeper.hpp
src/hotspot/share/runtime/vframe.cpp
src/hotspot/share/runtime/vframe.hpp
src/hotspot/share/runtime/vframe.inline.hpp
src/hotspot/share/runtime/vframeArray.cpp
src/hotspot/share/runtime/vframeArray.hpp
src/hotspot/share/runtime/vframe_hp.cpp
src/hotspot/share/runtime/vframe_hp.hpp
As stated in another comment, the following files should also be for `hotspot-compiler-dev`:
src/hotspot/share/memory/heap.hpp
src/hotspot/share/memory/heap.inline.hpp
src/hotspot/share/memory/heap.cpp

-------------

PR: https://git.openjdk.java.net/skara/pull/746