RFR: mlrules: applying off-list suggestions

Erik Helin ehelin at openjdk.java.net
Fri Aug 28 10:37:50 UTC 2020


On Fri, 28 Aug 2020 07:58:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Comment from GC maintainer regarding hotspot-gc-dev - change:
>> "src/hotspot/share/memory/(heap|oop)",
>> into
>> "src/hotspot/share/memory/oop",
>> 
>> The files `src/hotspot/share/memory/heap.{hpp,cpp}` actually for the code heap (and are thus most often reviewed on
>> hotspot-compiler-dev). As a GC reviewer I should have caught this too ��
>
> I received the following feedback regarding `hotspot-compiler-dev` - change:
> src/jdk.aot/share/classes/jdk.tools.jaotc
> into just
> src/jdk.aot/
> and add the following files:
> src/hotspot/share/runtime/icache.cpp
> src/hotspot/share/runtime/icache.hpp
> src/hotspot/share/runtime/registerMap.hpp
> src/hotspot/share/runtime/sharedRuntime.cpp
> src/hotspot/share/runtime/sharedRuntime.hpp
> src/hotspot/share/runtime/sharedRuntimeMath.hpp
> src/hotspot/share/runtime/sharedRuntimeTrans.cpp
> src/hotspot/share/runtime/sharedRuntimeTrig.cpp
> src/hotspot/share/runtime/stubCodeGenerator.hpp
> src/hotspot/share/runtime/sweeper.cpp
> src/hotspot/share/runtime/sweeper.hpp
> src/hotspot/share/runtime/vframe.cpp
> src/hotspot/share/runtime/vframe.hpp
> src/hotspot/share/runtime/vframe.inline.hpp
> src/hotspot/share/runtime/vframeArray.cpp
> src/hotspot/share/runtime/vframeArray.hpp
> src/hotspot/share/runtime/vframe_hp.cpp
> src/hotspot/share/runtime/vframe_hp.hpp
> As stated in another comment, the following files should also be for `hotspot-compiler-dev`:
> src/hotspot/share/memory/heap.hpp
> src/hotspot/share/memory/heap.inline.hpp
> src/hotspot/share/memory/heap.cpp

Additional suggestion to add the following for "jdk-dev":
README.md
CONTRIBUTING.md
LICENSE
ASSEMBLY_EXCEPTION
ADDITIONAL_LICENSE_INFO

-------------

PR: https://git.openjdk.java.net/skara/pull/746


More information about the skara-dev mailing list