RFR: git-pr: git diff can exit with code 141

Erik Helin ehelin at openjdk.java.net
Fri Feb 7 15:04:22 UTC 2020

Hi all,

please review this small patch that allows `git diff` to exit with code 141
during the `git pr show` command. `git diff` might exit with code 141 if it is
using a pager (e.g. `less`) that works with signals (e.g. `SIGPIPE`). For
example, if a user is viewing a large(r) patch using `git diff` using `less` and
presses "q", then `SIGPIPE` is sent to `git diff` which therefore will exit with
code 128 + 13 = 141 (`SIGPIPE` is signal 13).

The fix is simple, just make `git pr show` allow `git diff` to exit with code

- Manual testing of `git pr show`



 - d9f6fea1: Remove trailing whitespace
 - 6820b2ac: git-pr: git diff can exit with code 141

Changes: https://git.openjdk.java.net/skara/pull/413/files
 Webrev: https://webrevs.openjdk.java.net/skara/413/webrev.00
  Stats: 10 lines in 1 file changed: 7 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/413.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/413/head:pull/413

PR: https://git.openjdk.java.net/skara/pull/413

More information about the skara-dev mailing list