RFR: git-pr: git diff can exit with code 141

Robin Westberg rwestberg at openjdk.java.net
Fri Feb 7 15:06:32 UTC 2020

On Fri, 7 Feb 2020 14:55:03 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that allows `git diff` to exit with code 141
> during the `git pr show` command. `git diff` might exit with code 141 if it is
> using a pager (e.g. `less`) that works with signals (e.g. `SIGPIPE`). For
> example, if a user is viewing a large(r) patch using `git diff` using `less` and
> presses "q", then `SIGPIPE` is sent to `git diff` which therefore will exit with
> code 128 + 13 = 141 (`SIGPIPE` is signal 13).
> The fix is simple, just make `git pr show` allow `git diff` to exit with code
> 141.
> Testing:
> - Manual testing of `git pr show`
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/413

More information about the skara-dev mailing list