RFR: git-webrev: create links for bug ids in commit messages

Robin Westberg rwestberg at openjdk.java.net
Mon Feb 17 15:58:33 UTC 2020

On Mon, 17 Feb 2020 15:29:00 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that creates links to
> [JBS](https://bugs.openjdk.java.net) for issue id:s in commit messages. This
> patch also creates a link to the upstream revision if possible. Finally I also
> updated some of the titles to match `webrev.ksh`.
> The reason for not using the types `IssueProject` and `PullRequest` is that
> `webrev.ksh` has traditionally never required a network connection. The bots
> however are free to do so and can therefore provide better implementations for
> `issueLinker` and `commitLinker`. This work will be done in a follow-up patch.
> Testing:
> - `make test` passes on Linux x64
> - Manual testing of `git-webrev`
> Thanks,
> Erik

Looks good!

Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS:
        if [[ -n $WGET ]]; then
            msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>[(.*)] (.*) - Java Bug System</title>/\1 : \2/' | html_dequote | html_quote`
        if [[ -z $msg ]]; then

But such an implementation can certainly be left for later.


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/444

More information about the skara-dev mailing list