RFR: git-webrev: create links for bug ids in commit messages

[Erik Helin]

On Mon, 17 Feb 2020 15:56:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that creates links to
>> [JBS](https://bugs.openjdk.java.net) for issue id:s in commit messages. This
>> patch also creates a link to the upstream revision if possible. Finally I also
>> updated some of the titles to match `webrev.ksh`.
>> 
>> The reason for not using the types `IssueProject` and `PullRequest` is that
>> `webrev.ksh` has traditionally never required a network connection. The bots
>> however are free to do so and can therefore provide better implementations for
>> `issueLinker` and `commitLinker`. This work will be done in a follow-up patch.
>> 
>> Testing:
>> - `make test` passes on Linux x64
>> - Manual testing of `git-webrev`
>> 
>> Thanks,
>> Erik
> 
> Looks good!
> 
> Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS:
>         if [[ -n $WGET ]]; then
>             msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>[(.*)] (.*) - Java Bug System</title>/\1 : \2/' | html_dequote | html_quote`
>         fi
>         if [[ -z $msg ]]; then
>             msg="${id}"
>         fi
> 
> But such an implementation can certainly be left for later.

> Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS:

Ah. right, now I remember. We may or may not want to do that, `git-webrev` is _really_ fast in offline mode ��

-------------

PR: https://git.openjdk.java.net/skara/pull/444