[Rev 01] RFR: Add checkout instructions to PR body

Erik Helin ehelin at openjdk.java.net
Tue Feb 18 07:57:14 UTC 2020

On Mon, 17 Feb 2020 14:59:26 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
> Nice work! Just a small nit, you can use a Markdown [thematic break](https://spec.commonmark.org/0.29/#thematic-break) instead of using the `<hr />` HTML tag directly.

It seems like the test `org.openjdk.skara.bots.pr.ContributorTests > prBodyUpdates` is failing on both Linux and Mac. I think you have to change these two lines:

- https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L335
   `                if (line.equals("## Contributors")) {`
- https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L355
   `                assertNotEquals("## Contributors", line);`


PR: https://git.openjdk.java.net/skara/pull/434

More information about the skara-dev mailing list