[Rev 01] RFR: git-pr: support git pr create --draft

Robin Westberg rwestberg at openjdk.java.net
Wed Feb 19 10:15:10 UTC 2020

On Wed, 19 Feb 2020 10:14:51 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch adds support for `--draft` switch to `git pr create`.
>> Testing:
>> - Manual testing of `git pr create`
>> Thanks,
>> Erik
> The pull request has been updated with 1 additional commit.

Looks good, just a naming comment, can keep as is as well! But remember to update TestPullRequest as well.

forge/src/main/java/org/openjdk/skara/forge/PullRequest.java line 138:

> 137:     boolean isDraft();
> 138:     void makeNotDraft();
> 139: }

While symmetrical, perhaps `makeFinal` or `makeReady` would look nicer.. But if so `isDraft` should perhaps be `isFinal` as well.


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/454

More information about the skara-dev mailing list