[Rev 01] RFR: git-pr: support git pr create --draft

Erik Helin ehelin at openjdk.java.net
Thu Feb 20 14:52:40 UTC 2020

On Wed, 19 Feb 2020 10:01:47 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> forge/src/main/java/org/openjdk/skara/forge/PullRequest.java line 138:
>> 137:     boolean isDraft();
>> 138:     void makeNotDraft();
>> 139: }
> While symmetrical, perhaps `makeFinal` or `makeReady` would look nicer.. But if so `isDraft` should perhaps be `isFinal` as well.

Yeah, I sort of agree. However both platforms (GitHub and GitLab) does not have a word for the "not draft" state. So to make it very clear I think I prefer the current verbose (and slightly weird) naming to be make the code clearer.


PR: https://git.openjdk.java.net/skara/pull/454

More information about the skara-dev mailing list