RFR: forge: add method diffUrl to PullRequest

Erik Helin ehelin at openjdk.java.net
Thu Feb 20 10:25:00 UTC 2020


Hi all,

please review this small patch that adds the method `PullRequest::diffUrl`.
Although the implementation is the same for both `GitHubPullRequest` and
`GitLabMergeRequest` I chose to not do a `default` method to highlight that this
is more of a coincidence than a rule.

Thanks,
Erik

-------------

Commits:
 - 89faf8e2: forge: add method diffUrl to PullRequest

Changes: https://git.openjdk.java.net/skara/pull/459/files
 Webrev: https://webrevs.openjdk.java.net/skara/459/webrev.00
  Stats: 32 lines in 6 files changed: 25 ins; 4 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/459.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/459/head:pull/459

PR: https://git.openjdk.java.net/skara/pull/459


More information about the skara-dev mailing list