RFR: git-jcheck: remove --local, add --ignore

Erik Helin ehelin at openjdk.java.net
Fri Feb 21 14:14:08 UTC 2020

Hi all,

please review this patch that removes the flags `--local` and `--pull-request`
from `git-jcheck` and instead adds the more general `--ignore` flag. For
example, `git jcheck --local` now becomes `git jcheck
--ignore=branches,committer,reviewers,issues`. Since all errors from
`git-jcheck` includes the name of the check that cause the error, it is pretty
easy to iteratively come up with a custom `--ignore` value.

- Manual testing of `git-jcheck` and `git-pr create --jcheck` on Linux x64



 - b9a07ee8: git-jcheck: remove --local, add --ignore

Changes: https://git.openjdk.java.net/skara/pull/465/files
 Webrev: https://webrevs.openjdk.java.net/skara/465/webrev.00
  Stats: 204 lines in 3 files changed: 80 ins; 38 del; 86 mod
  Patch: https://git.openjdk.java.net/skara/pull/465.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/465/head:pull/465

PR: https://git.openjdk.java.net/skara/pull/465

More information about the skara-dev mailing list