RFR: git-jcheck: remove --local, add --ignore

Robin Westberg rwestberg at openjdk.java.net
Fri Feb 21 14:15:54 UTC 2020

On Fri, 21 Feb 2020 14:08:43 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that removes the flags `--local` and `--pull-request`
> from `git-jcheck` and instead adds the more general `--ignore` flag. For
> example, `git jcheck --local` now becomes `git jcheck
> --ignore=branches,committer,reviewers,issues`. Since all errors from
> `git-jcheck` includes the name of the check that cause the error, it is pretty
> easy to iteratively come up with a custom `--ignore` value.
> Testing:
> - Manual testing of `git-jcheck` and `git-pr create --jcheck` on Linux x64
> Thanks,
> Erik

Looks good to me!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/465

More information about the skara-dev mailing list