RFR: 217: Enforce check on number of required reviewers

Kevin Rushforth kcr at openjdk.java.net
Fri Jan 17 13:30:32 UTC 2020


On Fri, 17 Jan 2020 13:11:56 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that allows Reviewers of a PR to override the default number of required reviews as configured in the jcheck configuration file.
> 
> Best regards,
> Robin

In addition to allowing a reviewer to increase the required number of reviewers, which is the use case described in the Enhancement request, this will allow a reviewer to reduce the number of required reviewers below the minimum set in `.jcheck/conf`, including setting it to 0, right? Is this what we want?

-------------

PR: https://git.openjdk.java.net/skara/pull/364


More information about the skara-dev mailing list