RFR: 217: Enforce check on number of required reviewers

Kevin Rushforth kcr at openjdk.java.net
Fri Jan 17 14:28:12 UTC 2020

On Fri, 17 Jan 2020 13:30:24 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Hi all,
>> Please review this change that allows Reviewers of a PR to override the default number of required reviews as configured in the jcheck configuration file.
>> Best regards,
>> Robin
> In addition to allowing a reviewer to increase the required number of reviewers, which is the use case described in the Enhancement request, this will allow a reviewer to reduce the number of required reviewers below the minimum set in `.jcheck/conf`, including setting it to 0, right? Is this what we want?

One more question: If I increase the number of required reviewers to 2, does that mean both have to have the Reviewer role? If so, this won't be nearly as useful to us on the openjfx project. I suspect the same is true of many sub-projects in the JDK itself. For example, the policy in the client team is that fixes in general need 2 reviewers, at least one of which must be a "R" reviewer. OpenJFX has a similar policy (except that only "high-impact" fixes need a second reviewer) in that one one of the reviewers needs to be a "R" reviewer.


PR: https://git.openjdk.java.net/skara/pull/364

More information about the skara-dev mailing list