RFR: 234: Allow more granular jcheck reviewer configuration

Erik Helin ehelin at openjdk.java.net
Mon Jan 20 14:51:50 UTC 2020

Hi all,

please review this patch that allows for more granular reviewers configuration
with jcheck. With this patch a project can now specify exactly how many
reviewers are need for each role, for example:

[checks "reviewer"]
reviewer = 1
committer = 1
author = 1

The above configuration would require three reviewers in total, out of which one
must be reviewer, one must be committer and one must be author. This granularity
of configuration is needed to fully implement [PR 364](https://git.openjdk.java.net/skara/pulls/364).

I made sure that the patch is backwards compatible, we still support the old
configuration syntax:

[checks "reviewer"]
minimum = 1
role = reviewer

The above will simply be translated to the following configuration:

[checks "reviewer"]
reviewer = 1


## Testing
- [x] Added a number of additional unit tests


 - 7ce157a2: skara-234

Changes: https://git.openjdk.java.net/skara/pull/368/files
 Webrev: https://webrevs.openjdk.java.net/skara/368/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-234
  Stats: 260 lines in 6 files changed: 216 ins; 11 del; 33 mod
  Patch: https://git.openjdk.java.net/skara/pull/368.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/368/head:pull/368

PR: https://git.openjdk.java.net/skara/pull/368

More information about the skara-dev mailing list